Fix/refactor zboxcore mobilesdk fixes #1633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expose GetVersion method.
…fix/refactor-zboxcore-mobilesdk-fixes
…rders and blobbers. exposed Faucet method.
yash10019coder
requested review from
peterlimg,
dabasov and
guruhubb
as code owners
…fix/refactor-zboxcore-mobilesdk-fixes
…fix/refactor-zboxcore-mobilesdk-fixes
dabasov
requested changes
Oct 14, 2024
yash10019coder
commented
Jan 23, 2025
| @@ -156,7 +156,7 @@ func makeSCRestAPICall(scAddress, relativePath, paramsJson string) (string, erro | |||
| // - fee is the transaction fee | |||
| // - desc is the description of the transaction | |||
| func send(toClientID string, tokens uint64, fee uint64, desc string) (string, error) { | |||
| _, _, _, txn, err := zcncore.Send(toClientID, tokens, desc) | |||
There was a problem hiding this comment.
@Jayashsatolia403 @iamibadd custom fee passing here would be fine?
Since orignally it wasn't the caes but send method anyway has a fee parameter
There was a problem hiding this comment.
you can also pass 0 fee here as well if you pass 0 it'll estimate the fee automatically.
* sprint-1.19: Move zauth to core Fix sign auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
expose GetBlobbers method.
expose GetStorageConfig method.
expose GetVersion method.
expose ConvertToValue method.
exposed staking, unstaking and collect reward methods for miners, sharders and blobbers.
exposed Faucet method.
expose GetStakePoolUserInfo.
Fix
Setup auth
fix: fixed restriction setup
fix: fixed bugs
fix: fixed bugs
fix: fixed bugs
fix: fixed bugs
fix: fixed bugs
Fix
add docs for expose GetStakePoolUserInfo method.
expose VerifyTransaction method.
expose GetTransactions method in gosdk.
expose GetFeesTable method.
fix: error initializing sdk.
fix: GetTransactions method.
fix: init_node.go network initialization.
fix: sdk not initialized error for zboxcore methods.
refactor: add provider type field in StakePoolDelegatePoolInfo.
debug: mobile build flagsin mobilesdk/sdk.go.
debug: playground script.
refactor: combined blobber and miner/sharder user stake pool info.
go mod tidy
fix: add provider id in StakePoolDelegatePoolInfo.
expose: GetConfig method.
remove faucet method from mobilesdk.
fix: InitStorageSDK method error.
refactor: add custom fees to all of the mobilesdk methods for staking, unstaking and claim rewards.
refactor: add fees in sendZCN.
fix: wasmsdk send token to pass fee parameter.
expose: client.Sign
expose: sdk.GetClientEncryptedPublicKey
expose: CreateThumbnail method.
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):